Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to v4.1.0-dev #13698

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Bump version to v4.1.0-dev #13698

merged 4 commits into from
Apr 27, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Mar 29, 2022

I think we forgot to bump the version in the main branch. It should be
v4.1.0-dev now.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@mheon
Copy link
Member

mheon commented Mar 29, 2022

LGTM

@Luap99
Copy link
Member Author

Luap99 commented Mar 29, 2022

@jwhonce PTAL at the bindings test failure.

@jwhonce
Copy link
Member

jwhonce commented Apr 4, 2022 •
edited
Loading

@Luap99

https://github.com/containers/podman/blob/main/pkg/bindings/test/manifests_test.go#L99 should be Expect(code).To(BeNumerically("==", http.StatusBadRequest)) from reading the handler code. I made the change in #13274 to better match the other endpoints and documentation. The worrisome issue is why did it take this long to manifest?

semvar tested here, https://go.dev/play/p/GH8K1hN5bTZ

@Luap99 Luap99 force-pushed the version branch 2 times, most recently from 92b7cdc to a972aaf Compare April 27, 2022 10:45
Luap99 added 4 commits April 27, 2022 14:32
@Luap99
Bump version to v4.1.0-dev
609b52f 
I think we forgot to bump the version in the main branch. It should be
v4.1.0-dev now.
Also set the min api version to 4.0.0 as on the podman 4.0 branch.

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
fix manifest modify endpoint to respect tlsverify param
e9599fb 
Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
pkg/bindings: manifest remove 3.X API support conditional
4a4906b 
Since the minimum API version is set to 4.0.0 the endpoint will not talk
to the 3.X endpoint. Therefore this logic is broken and should just be
removed. 4.0 bindings should only talk to 4.0 server. This is already
the case for many other endpoints.

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
manifest endpoints fix ordering
3bcfd25 
OK this is a pretty bad design IMO. We have to endpoints:
manifest create: `POST /{name}`
manifest push: `POST /{name}/registry/{destination}`

So basically all push requests are valid create requests.
Fortunately we can change the order in which the endpoints are matched.
If the logic matches push first it will fall back to create if the
request does not have the `/registry/{}` part.

Signed-off-by: Paul Holzinger <[email protected]>
vrothberg
vrothberg reviewed Apr 27, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon
Copy link
Member

mheon commented Apr 27, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2022
@mheon
Copy link
Member

mheon commented Apr 27, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9133a6d into containers:main Apr 27, 2022
@Luap99 Luap99 deleted the version branch April 27, 2022 14:57
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Luap99 @mheon @jwhonce @vrothberg @openshift-merge-robot