Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes errors from 'manifest push' being dropped in remote case #13651

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

jwmatthews
Copy link
Contributor

Signed-off-by: John Matthews [email protected]

Fixes #13650

@rhatdan
Copy link
Member

rhatdan commented Mar 24, 2022

LGTM
@containers/podman-maintainers PTAL
@jwhonce PTAL

@mheon
Copy link
Member

mheon commented Mar 24, 2022

PR is complaining about a lack of tests. You can add a test, or add [NO NEW TESTS NEEDED] somewhere in your commit message

@Luap99
Copy link
Member

Luap99 commented Mar 24, 2022

Please do not add NO NEW TEST NEEDED for such changes. This looks like important functionallity so we need a test for it to not regress again in the future.

@jwmatthews
Copy link
Contributor Author

@Luap99 ok, I will work on adding a test for this.

I wasn't sure how to execute the tests from mac, but I have them running now on Linux.
Will add a test to this PR.

@jwmatthews
Copy link
Contributor Author

@Luap99 I've updated the commit with a test

@jwhonce
Copy link
Member

jwhonce commented Mar 25, 2022

/hold
/lgtm

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 26, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwmatthews, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 27, 2022

@jwmatthews Needs a rebase.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2022
@jwmatthews
Copy link
Contributor Author

jwmatthews commented Mar 27, 2022

Rebased after #13653 was merged

@mheon
Copy link
Member

mheon commented Mar 28, 2022

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 54f808e into containers:main Mar 28, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error from remote 'manifest push' is hidden
6 participants