-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes errors from 'manifest push' being dropped in remote case #13651
Conversation
LGTM |
PR is complaining about a lack of tests. You can add a test, or add |
Please do not add |
@Luap99 ok, I will work on adding a test for this. I wasn't sure how to execute the tests from mac, but I have them running now on Linux. |
@Luap99 I've updated the commit with a test |
/hold |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwmatthews, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jwmatthews Needs a rebase. |
Signed-off-by: John Matthews <[email protected]>
Rebased after #13653 was merged |
/lgtm |
Signed-off-by: John Matthews [email protected]
Fixes #13650