Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/prometheus/client_golang to v1.11.1 #13642

Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Mar 24, 2022

Resolves: CVE-2022-21698

Signed-off-by: Lokesh Mandvekar [email protected]

@mheon @rhatdan @baude @vrothberg PTAL
/cc @containers/podman-maintainers

@Luap99
Copy link
Member

Luap99 commented Mar 24, 2022

Ref containers/image#1487 which would remove this from our dependencies completely

go.mod Outdated Show resolved Hide resolved
@lsm5 lsm5 force-pushed the v3.4.2-rhel-cve-2022-21698 branch from 2e2974d to 03edd1a Compare March 24, 2022 13:58
go.mod Outdated Show resolved Hide resolved
@lsm5 lsm5 force-pushed the v3.4.2-rhel-cve-2022-21698 branch from 03edd1a to 10f79f8 Compare March 24, 2022 14:06
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsm5 lsm5 force-pushed the v3.4.2-rhel-cve-2022-21698 branch from 10f79f8 to aa9cad0 Compare March 24, 2022 14:16
@lsm5 lsm5 changed the title Use github.com/prometheus/client_golang v1.11.1 Bump github.com/prometheus/client_golang to v1.11.1 Mar 24, 2022
@mheon
Copy link
Member

mheon commented Mar 24, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 24, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
@mheon
Copy link
Member

mheon commented Mar 24, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit f0b1c09 into containers:v3.4.2-rhel Mar 24, 2022
@lsm5 lsm5 deleted the v3.4.2-rhel-cve-2022-21698 branch March 29, 2022 13:36
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants