-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly use IPv4 to check if podman-machine VM is listening #13617
Explicitly use IPv4 to check if podman-machine VM is listening #13617
Conversation
LGTM |
/approve |
/approve |
If gvproxy only listens on 127.0.0.1, why not just replace localhost with 127.0.0.1 here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: holzman, mheon, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Either works (and is equally readable as far as I'm concerned). I can change it if reviewers prefer. |
I prefer 127.0.0.1 because AFAIK you could in theory change localhost to another ip but I guess in this case many things would break. |
You also have to add |
When starting a VM that has been configured with volume mounts, the podman client attempts to connect via TCP to localhost, which runs gvproxy to proxy an ephemeral port to the VM's ssh port. Previously, gvproxy was listening on all interfaces and IP addresses, but this behavior has changed to listening only on the IPv4 loopback address. Without this change, if a newer build of gvproxy is used, a podman machine configured with volume mounts will hang forever after "podman machine start" with "Waiting for VM ...". [NO NEW TESTS NEEDED] Signed-off-by: Burt Holzman <[email protected]>
90c685d
to
cdda192
Compare
/lgtm |
/lgtm |
/hold cancel |
When starting a VM that has been configured with volume mounts, the podman client attempts to connect via
TCP to localhost, which runs gvproxy to proxy an ephemeral port to the VM's ssh port. Previously, gvproxy
was listening on all interfaces and IP addresses, but this behavior has changed to listening only on the
IPv4 loopback address.
Without this change, if a newer build of gvproxy is used, a podman machine configured with volume mounts
will hang forever after "podman machine start" with "Waiting for VM ...".
Signed-off-by: Burt Holzman [email protected]