Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compose test error in retry logic #13593

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Mar 22, 2022

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
@Luap99
Copy link
Member Author

Luap99 commented Mar 22, 2022

@edsantiago PTAL

Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for cleanup. Also, title is wrong: this is not a flake, this is a hard failure

test/compose/slirp4netns_opts/tests.sh Show resolved Hide resolved
@Luap99
Copy link
Member Author

Luap99 commented Mar 22, 2022

This is still a flake, #13558 passed tests so it works unless it has to use the retry logic.

@Luap99 Luap99 changed the title fix compose flake v2 fix compose test error in retry logic Mar 22, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 22, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 22, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit c840f64 into containers:main Mar 22, 2022
@Luap99 Luap99 deleted the compose-flakev2 branch March 22, 2022 18:38
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants