pod system tests: clean up stray image #13574
Conversation
One of the pod tests was leaving a stray image behind, causing scary red warnings in CI logs. Clean that up. Also, now that containers#13541 has merged, use 'rmi --ignore' instead of ignoring exit status from rmi Signed-off-by: Ed Santiago <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
| local pod_name="$(random_string 10 | tr A-Z a-z)" | ||
|
|
||
| run_podman --noout pod create --name $pod_name --infra-name "$infra_name" --infra-image "k8s.gcr.io/pause:3.5" | ||
| is "$output" "" "output should be empty" | ||
| run_podman --noout pod create --name $pod_name --infra-name "$infra_name" --infra-image "$infra_image" |
There was a problem hiding this comment.
Why do we use --infra-image here? The test is about --infra-name and I see no reasons why this requires a special infra image.
There was a problem hiding this comment.
Not a question I could possibly answer. As best I can tell, it was introduced in #11956, so @vrothberg can you answer this?
There was a problem hiding this comment.
Probably to make sure --infra-image is working.
|
Confirmation: I've looked at all the |
github-actions
bot
added
the
locked - please file new issue/PR
One of the pod tests was leaving a stray image behind,
causing scary red warnings in CI logs. Clean that up.
Also, now that #13541 has merged, use 'rmi --ignore' instead of
ignoring exit status from rmi
Signed-off-by: Ed Santiago [email protected]