Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.0] Backport: Fix windows win-sshproxy build #13545

Merged
merged 1 commit into from
Mar 18, 2022
Merged

[v4.0] Backport: Fix windows win-sshproxy build #13545

merged 1 commit into from
Mar 18, 2022

Conversation

cevich
Copy link
Member

@cevich cevich commented Mar 17, 2022

Github no longer supports the unauthenticated git protocol, so switch
to using https instead.

https://github.blog/2021-09-01-improving-git-protocol-security-github/

Signed-off-by: Paul Holzinger [email protected]

@Luap99 @cevich
Fix windows win-sshproxy build
f83d437 
Github no longer supports the unauthenticated git protocol, so switch
to using https instead.

https://github.blog/2021-09-01-improving-git-protocol-security-github/

Signed-off-by: Paul Holzinger <[email protected]>
@cevich cevich requested a review from Luap99 March 17, 2022 18:07
@cevich
Copy link
Member Author

cevich commented Mar 17, 2022

Note: This is intended to fix Cirrus-cron failures on this branch. Ref: https://cirrus-ci.com/build/6315637885632512

Luap99
Luap99 approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think we need this in the v4.0-rhel branch as well.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
@cevich
Copy link
Member Author

cevich commented Mar 17, 2022

I think we need this in the v4.0-rhel branch as well.

Oh! Thanks for mentioning that, we're not running any daily testing on that branch. I'll fix that right now...

@ashley-cui
Copy link
Member

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022
@cevich
Copy link
Member Author

cevich commented Mar 17, 2022

...okay, I added a job for the v4.0-rhel branch to run daily. I'll make another PR for that too...

@cevich cevich mentioned this pull request Mar 17, 2022
Merged
@TomSweeneyRedHat
Copy link
Member

LGTM
and merging as this won't affect the RHEL delivery, just make our builds happier.

@TomSweeneyRedHat
Copy link
Member

/lgtm

@rhatdan
Copy link
Member

rhatdan commented Mar 18, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2022
@openshift-merge-robot openshift-merge-robot merged commit e3184e9 into containers:v4.0 Mar 18, 2022
@seantwie03 seantwie03 mentioned this pull request Mar 28, 2022
Closed
@cevich cevich deleted the backport_gvisor_url_fix branch April 18, 2023 14:46
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 approved these changes

Assignees

@TomSweeneyRedHat TomSweeneyRedHat

@ashley-cui ashley-cui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cevich @ashley-cui @TomSweeneyRedHat @rhatdan @Luap99 @openshift-merge-robot