podman create: building local pause image: do not read ignore files #13530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
edsantiago
reviewed
Mar 16, 2022
|
@edsantiago updated. I tried making up by consolidating places using the local pause image. |
|
@containers/podman-maintainers PTAL /hold |
openshift-ci
bot
added
the
do-not-merge/hold
edsantiago
reviewed
Mar 17, 2022
edsantiago
reviewed
Mar 17, 2022
Make sure to ignore local {container,docker}ignore files when building a
local pause image. Otherwise, we may mistakenly not be able to copy
catatonit into the build container.
Fixes: containers#13529
Signed-off-by: Valentin Rothberg <[email protected]>
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm again (because my first one was in a review comment, and I discovered this week that github review comments are treated differently from PR comments) |
|
(Nope, my slash-lgtm had no effect; I had to manually use clickybuttons to add the label. githubstatus claims that all is well, but earlier this morning things were very broken, so it's possible that something is still broken). |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to ignore local {container,docker}ignore files when building a
local pause image. Otherwise, we may mistakenly not be able to copy
catatonit into the build container.
Fixes: #13529
Signed-off-by: Valentin Rothberg [email protected]