-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set rawimage for containers created via play kube #13527
Set rawimage for containers created via play kube #13527
Conversation
LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: machacekondra, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but note that auto-update does not support containers created via play kube.
/lgtm |
I was just about to ask this. @machacekondra You have to rebase to the latest main to fix the windows build test. |
Well, the only way I was able to make it work via play kube was: apiVersion: v1
kind: Pod
metadata:
name: mypod
labels:
io.containers.autoupdate: registry
PODMAN_SYSTEMD_UNIT: mypod.service
spec:
containers:
- name: test-container
image: quay.io/bitnami/nginx:latest The labels are propageted here: https://github.com/containers/podman/blob/main/pkg/domain/infra/abi/play.go#L440 |
This commit set the containers RawImageName to default image name specified in Pod YAML, so the containers could be used via autoupdate feature, which needs the RawImageName to be set. Currently RawImageName is set only for the create/run/clone podman commands. [NO NEW TESTS NEEDED] Signed-off-by: Ondra Machacek <[email protected]>
6aa8d3c
to
449f2fc
Compare
/lgtm |
This commit set the containers RawImageName to default image name
specified in Pod YAML, so the containers could be used via autoupdate
feature, which needs the RawImageName to be set.
Currently RawImageName is set only for the create/run/clone podman
commands.
Previously if
auto-update
command was executed on containers created bypodman play kube
we got ouput: