-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tolerate old machine images, but warn they should be recreated #13523
Tolerate old machine images, but warn they should be recreated #13523
Conversation
@baude not sure if you prefer this to outright fail on start. |
8554ad2
to
bba3124
Compare
I think this should fail. Won't podman blow up trying to communicate with the podman service within the VM? Or do you want to allow users to enter then VM via podman machine ssh, and update it? |
I think it would be good to allow it to start so users can ssh into it and save their data before nuking the machine. |
Ok how about I change this to have a louder warning on start to that effect? It will say that the machine is no longer compatible and is starting only to allow you to copy your data off. |
SGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should backport this to 4.0
Start in a reduced mode for recovery, warn, and provide instructions to recreate them Signed-off-by: Jason T. Greene <[email protected]>
bba3124
to
3c968c3
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #13510
Machine instances created on podman 3 will be incompatible with podman current podman remote.
Let them run in a reduced mode and warn there will be problems and should be recreated.
Output:
[NO NEW TESTS NEEDED]