Fix typo

[rst0git]

No description provided.

[zhangguanzhang]

code LGTM, bug title or commit messages need a [NO TEST NEEDED]

[flouthoc]

LGTM but [NO NEW TESTS NEEDED] is needed as requested by @zhangguanzhang

[rst0git]

Thanks, I added [NO NEW TESTS NEEDED] in the commit message.

[rhatdan]

/approve
/lgtm
/hold
Thanks @rst0git

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, rst0git, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan,zhangguanzhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[umohnani8]

/hold cancel

[Luap99]

This should be reverted in IMO, this is a breaking change for everyone using the binding with this parameter.
So if we want to keep the stability promise we cannot change this until 5.0!
@containers/podman-maintainers PTAL

[rst0git]

this is a breaking change for everyone using the binding with this parameter.

@Luap99 As far as I know, podman-remote does not support container restore with --import.

cc: @adrianreber

[Luap99]

Well at least according to the code it is implemented and this is not about podman-remote.
pkg/bindings is used by other projects as dependency. We guarantee that this is stable and cannot break their code without a major release.
We discussed this as team and decided that we will add the old field back and alias it to the new correct name.

[vrothberg]

@rst0git no wrong doing on your end. We should have caught this during review.

As @Luap99 mentions above, there are certain APIs that we committed to keep stable with pkg/bindings being among them. We'll keep this change but add back the previous field and API. There may be some callers of it that would otherwise break when updating to the next version.

[rhatdan]

We could keep the old name with a big comment and call into the new name.

[Luap99]

We could keep the old name with a big comment and call into the new name.

That is the plan.

[Luap99]

#13514