Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve agent install message to add restart instructions #13465

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Improve agent install message to add restart instructions #13465

merged 1 commit into from
Mar 9, 2022

Conversation

n1hility
Copy link
Member

@n1hility n1hility commented Mar 8, 2022 •
edited
Loading

Improves the install instructions to include a machine restart which is required after the helper agent is installed.

See #13456

[NO NEW TESTS NEEDED]

@rhatdan
Copy link
Member

rhatdan commented Mar 8, 2022

[NO TESTS NEEDED]
Should be
[NO NEW TESTS NEEDED]

@rhatdan
Copy link
Member

rhatdan commented Mar 8, 2022

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM
and tests s/b happy after you change the tag as @rhatdan suggested.

@baude
Copy link
Member

baude commented Mar 8, 2022

code LGTM

@n1hility
Copy link
Member Author

n1hility commented Mar 9, 2022

[NO TESTS NEEDED]
Should be
[NO NEW TESTS NEEDED]

Oops! Fixed

@n1hility n1hility force-pushed the improve-install-msg branch from e413ae8 to a7c4691 Compare March 9, 2022 03:55
@n1hility
Copy link
Member Author

n1hility commented Mar 9, 2022

No code changes, I just force pushed a new sha to get tests to run

@rhatdan
Copy link
Member

rhatdan commented Mar 9, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n1hility, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 41e2c99 into containers:main Mar 9, 2022
@n1hility n1hility mentioned this pull request Mar 18, 2022
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@n1hility @rhatdan @TomSweeneyRedHat @baude @openshift-merge-robot