Fix handling of multiple filters in podman ps #1345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: manpages and bash completions probably also need updating |
test/e2e/ps_test.go
Outdated
| Expect(result.ExitCode()).To(Equal(0)) | ||
| Expect(result.OutputToStringArray()[0]).To(Equal(fullCid)) | ||
| }) | ||
|
|
There was a problem hiding this comment.
I think this new test might have succeeded with the old behavior. It might be good to create a second container with key1==value2 and then make sure you only get one container back.
|
I tested the PR and it fixed my bug. Thanks again @mheon ! |
Docker expects multiple filters to be passed with multiple uses of the --filter flag (e.g. --filter=label=a=b --filter=label=c=d) and not a single comma-separated list of filters as we expected. Convert to the Docker format, and make some small cleanups to our handling of filters along the way. Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
|
Fixed the test and added another container to make sure the match logic for multiple filters is logical-AND, and updated the manpage. This should be ready now. CI seems to be having its usual issues though. |
|
bot, retest this please |
|
LGTM |
|
@rh-atomic-bot r=umohnani8 |
|
📌 Commit 9c5f809 has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Aug 27, 2018
Signed-off-by: Matthew Heon <[email protected]> Closes: #1345 Approved by: umohnani8
|
☀️ Test successful - status-papr |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker expects multiple filters to be passed with multiple uses of the --filter flag (e.g. --filter=label=a=b --filter=label=c=d) and not a single comma-separated list of filters as we expected. Convert to the Docker format, and make some small cleanups to our handling of filters along the way.
Fixes #1341