RELEASE_PROCESS.md: build artifacts locally #13416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
The current PR process for release bump has the HEAD commit which bumps version/version.go to the form `release+1-dev`. This makes Cirrus publish release artifacts with `release+1-dev` and not `release`. For example, the msi generated at https://cirrus-ci.com/task/5403901196238848 says podman-v4.0.3-dev.msi . Building locally by checking out the released tag would generate the correct artifacts and would also be faster and more convenient. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
release-artifacts-process
branch
from
85ca86d to
a3497ce
Compare
cevich
reviewed
Mar 3, 2022
|
@rhatdan you should do /lgtm |
|
umm, I'd have preferred to wait for @mheon 's review, but I guess we can revise it once he gets back. No biggie. |
lsm5
added a commit
to lsm5/podman
that referenced
this pull request
Mar 7, 2022
Follow up to pr#13416 Insert line breaks to get rid of the horizontal scroll bar. Resolves: containers#13416 (comment) Co-authored-by: Ashley Cui <[email protected]> Signed-off-by: Lokesh Mandvekar <[email protected]>
tricktron
pushed a commit
to tricktron/podman
that referenced
this pull request
Mar 14, 2022
Follow up to pr#13416 Insert line breaks to get rid of the horizontal scroll bar. Resolves: containers#13416 (comment) Co-authored-by: Ashley Cui <[email protected]> Signed-off-by: Lokesh Mandvekar <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PR process for release bump has the HEAD commit which bumps
version/version.go to the form
release+1-dev. This makes Cirruspublish release artifacts with
release+1-devand notrelease.For example, the msi generated at https://cirrus-ci.com/task/5403901196238848
says podman-v4.0.3-dev.msi .
Building locally by checking out the released tag would generate the
correct artifacts and would also be faster and more convenient.
Signed-off-by: Lokesh Mandvekar [email protected]
@mheon @ashley-cui @TomSweeneyRedHat @rhatdan @baude PTAL
/cc @containers/podman-maintainers
DO NOT MERGE without LGTMs from @mheon and @ashley-cui