Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.0.2 #13405

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Release v4.0.2 #13405

merged 3 commits into from
Mar 2, 2022

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Mar 2, 2022

As the title says.

Tag v4.0.2 already added to the Bump to v4.0.2 commit.

@containers/podman-maintainers PTAL

lsm5 added 3 commits March 2, 2022 09:04
[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@ashley-cui
Copy link
Member

LGTM!

@TomSweeneyRedHat
Copy link
Member

LGTM
thanks @lsm5 !

@TomSweeneyRedHat
Copy link
Member

/lgtm
/hold # on tests

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 2, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit 717edd7 into containers:v4.0 Mar 2, 2022
@lsm5 lsm5 deleted the v402 branch March 2, 2022 16:47
@TomSweeneyRedHat
Copy link
Member

@lsm5 Can you create a tag/release for 4.0.2 please?

@vrothberg
Copy link
Member

If we're using the v4.0 branch in RHEL, we're doing it wrong. RHEL should only consume -rhel suffixed branches. But a v4.0-rhel doesn't seem to exist yet. We need to create one and revert this commit there.

@mheon @baude PTAL

@lsm5
Copy link
Member Author

lsm5 commented Mar 15, 2022

Can we please revert this @lsm5 ? The v4.0 branch is a maintenance branch. This change would mean users will see invalid version "4.0.3-dev" while doing "podman version" for debugging purposes. We were bitten by this multiple times in the past. In essence this branch is just 4.0.2 + backports. Thanks!

@jnovy Reverting a tagged release is going to be really painful. I think we best not revert. When I last did the rhel build, I didn't use HEAD from v4.0 but the commit id that bumped version from v4.0.2-dev to v4.0.2. So, unless that's changed in the rhel spec file, I would say we're good.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants