Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpod: drop warning if cgroup doesn't exist #13398

Merged

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Mar 2, 2022

do not print a warning on cgroup removal if it doesn't exist.

Closes: #13382

[NO NEW TESTS NEEDED]

Signed-off-by: Giuseppe Scrivano [email protected]

do not print a warning on cgroup removal if it doesn't exist.

Closes: containers#13382

[NO NEW TESTS NEEDED]

Signed-off-by: Giuseppe Scrivano <[email protected]>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@containers/podman-maintainers PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe giuseppe marked this pull request as draft March 2, 2022 10:26
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2022
@giuseppe
Copy link
Member Author

giuseppe commented Mar 2, 2022

marked as draft as I've worked on an alternative fix: #13403

I prefer more the other version as it addresses the root problem instead of covering it

@TomSweeneyRedHat
Copy link
Member

If you fall back to this @giuseppe , this LGTM

@giuseppe giuseppe marked this pull request as ready for review March 22, 2022 10:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2022
@mheon
Copy link
Member

mheon commented Mar 22, 2022

LGTM

@rhatdan
Copy link
Member

rhatdan commented Mar 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit b4b8b8b into containers:main Mar 22, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbus-launch and conmon/pids.max problem
6 participants