Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "use GetRuntimeDir() from c/common" #13391

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Revert "use GetRuntimeDir() from c/common" #13391

merged 1 commit into from
Mar 1, 2022

Conversation

baude
Copy link
Member

@baude baude commented Mar 1, 2022

This reverts commit fc5cf81.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@edsantiago edsantiago mentioned this pull request Mar 1, 2022
Merged
@baude
Revert "use GetRuntimeDir() from c/common"
22f331e 
This reverts commit fc5cf81.

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@edsantiago
Copy link
Member

/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Mar 1, 2022
@edsantiago edsantiago removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit a254086 into containers:main Mar 1, 2022
@vrothberg
Copy link
Member

This reverts commit fc5cf81.

Why? If there's something missing, we should fix c/common IMHO. Having redundant code/duplicate functionality invites divergence across the tools.

@rhatdan
Copy link
Member

rhatdan commented Mar 2, 2022

We are just doing this to get the release out.
We need to fix the common and then revendor and then this patch will be added back.

@vrothberg
Copy link
Member

No objections against that. I am just whining about this information not being public/obvious. No breadcrumbs in case we lose it from the radar.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@edsantiago edsantiago

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baude @edsantiago @vrothberg @rhatdan @openshift-merge-robot