Inspect network info of a joined network namespace #13366
Conversation
idleroamer
force-pushed
the
inspect-joined-network-ns-main
branch
from
d60f0f8 to
6c0c418
Compare
idleroamer
force-pushed
the
inspect-joined-network-ns-main
branch
from
6c0c418 to
3598684
Compare
|
I think your changes are breaking the tests because you do not handle setns correctly. Please use |
|
Hint: You can always check the status of 'main' here: https://cirrus-ci.com/github/containers/podman/main I agree with Paul, these don't look like systemic errors/failings. |
idleroamer
force-pushed
the
inspect-joined-network-ns-main
branch
9 times, most recently
from
f4f6c7b to
1f2ad7a
Compare
idleroamer
force-pushed
the
inspect-joined-network-ns-main
branch
7 times, most recently
from
d0275c8 to
f6f2385
Compare
|
@Luap99 @mheon thanks for the support. I found the culprit, it turned out usage of the following causes random failures in other test-cases on CI, no idea though why. |
libpod/networking_linux.go
Outdated
| subnets := make([]types.NetAddress, 0) | ||
| for _, address := range addrs { | ||
| if ipnet, ok := address.(*net.IPNet); ok { | ||
| subnets = append(subnets, types.NetAddress{ |
There was a problem hiding this comment.
I think you should skip ipv6 link local addresses
test/e2e/run_networking_test.go
Outdated
|
|
||
| It("podman run newtork inspect fails gracefully on non-reachable network ns", func() { | ||
| SkipIfRootless("ip netns is not supported for rootless users") | ||
| SkipIfContainerized("Cannot be run within a container.") |
There was a problem hiding this comment.
Cannot be run within a container, why? please provide the reason for this in the message
There was a problem hiding this comment.
I thought we can't create further network namespace inside container, but let's see if I was wrong.
There was a problem hiding this comment.
Obviously I was wrong, so removed SkipIfContainerized.
There was a problem hiding this comment.
Ok, I should add since I removed the SkipIfContainerized it seems that following setup presents a flake
https://cirrus-ci.com/task/5610690273607680
int podman fedora-35 rootless host
[+2250s] Summarizing 3 Failures:
[+2250s]
[+2250s] [Fail] podman system service verify pprof endpoints [It] are not available
[+2250s] /var/tmp/go/src/github.com/containers/podman/test/e2e/system_service_test.go:117
I can't establish any link to these test-cases though.
There was a problem hiding this comment.
Don't worry about this one: #12624
We can restart failed tests manually.
idleroamer
force-pushed
the
inspect-joined-network-ns-main
branch
5 times, most recently
from
39d31e1 to
a4da9c7
Compare
idleroamer
force-pushed
the
inspect-joined-network-ns-main
branch
2 times, most recently
from
9965838 to
3eaec1d
Compare
idleroamer
force-pushed
the
inspect-joined-network-ns-main
branch
2 times, most recently
from
501776d to
20244fa
Compare
Closes: containers#13150 Signed-off-by: 😎 Mostafa Emami <[email protected]>
idleroamer
force-pushed
the
inspect-joined-network-ns-main
branch
from
20244fa to
611b45c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: idleroamer, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Display network info of a joined network namespace upon inspect
Join network namespace and query interfaces/IPs/gateway
Closes: #13150
Signed-off-by: 😎 Mostafa Emami [email protected]