Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System tests: reenable once-flaky exec + stty test #13331

Closed
wants to merge 1 commit into from

Conversation

edsantiago
Copy link
Member

Ref: #10710, a nasty and frequent flake. I can no longer
reproduce the failure on f35 or Rawhide, so let's take
the risk of reenabling the test.

Signed-off-by: Ed Santiago [email protected]

Ref: containers#10710, a nasty and frequent flake. I can no longer
reproduce the failure on f35 or Rawhide, so let's take
the risk of reenabling the test.

Signed-off-by: Ed Santiago <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2022
@edsantiago edsantiago added the kind/cleanup Categorizes issue or PR as related to cleanup. label Feb 23, 2022
@edsantiago
Copy link
Member Author

Thanks to whomever restarted the flake, but that was EXACTLY the problem under question!

# $ podman-remote --url unix:/tmp/podman_tmp_VyGh exec -it mystty stty size
# stty: standard input

...so obviously we cannot merge this PR, and #10710 must remain open.

(FWIW, conmon on the failed CI system is 2.1.0-2.fc35, same as on my laptop on which I couldn't get a failure, so it's not something fixed in conmon).

@edsantiago edsantiago closed this Feb 24, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleanup. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant