container-commit: support --squash to squash layers into one if users want.
#13314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
vrothberg
reviewed
Feb 22, 2022
flouthoc
force-pushed
the
container-commit-squash
branch
2 times, most recently
from
aed2748 to
87f8185
Compare
|
@vrothberg Thanks :) added to swagger as well. Lets see if tests passes. |
| @@ -77,6 +77,7 @@ func commitFlags(cmd *cobra.Command) { | |||
|
|
|||
| flags.BoolVarP(&commitOptions.Pause, "pause", "p", false, "Pause container during commit") | |||
| flags.BoolVarP(&commitOptions.Quiet, "quiet", "q", false, "Suppress output") | |||
| flags.BoolVarP(&commitOptions.Squash, "squash", "s", false, "squash newly built layers into a single new layer") | |||
There was a problem hiding this comment.
Losing my marbles I am, I thought we had this for commit already....
|
Changes LGTM, test unhappiness does not. |
Allow users to commit containers into a single layer. Usage ```bash podman container commit --squash <name> ``` Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
container-commit-squash
branch
from
87f8185 to
fbbcb95
Compare
|
@containers/podman-maintainers PTAL |
|
LGTM |
|
/lgtm |
rhatdan
added
the
kind/feature
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to commit containers into a single layer.
Usage
Closes: #12889