Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to v4.0.0 final #13255

Merged
merged 17 commits into from
Feb 17, 2022
Merged

Bump to v4.0.0 final #13255

merged 17 commits into from
Feb 17, 2022

Conversation

mheon
Copy link
Member

@mheon mheon commented Feb 16, 2022

As the title says. Final backports, release notes updates, and the version bump.

jwhonce and others added 12 commits February 16, 2022 13:55
@jwhonce @mheon
Add 409 response to swagger godoc
975d79a 
When attempting to create a network with a name that already exists,
a 409 status code will be returned

[NO NEW TESTS NEEDED]

Signed-off-by: Jhon Honce <[email protected]>
@rhatdan @mheon
Make sure building with relative paths work correctly.
a72e221 
Fixes: containers#12763

Signed-off-by: Daniel J Walsh <[email protected]>
@adrianreber @mheon
Fix checkpoint/restore pod tests
d77b4f9 
Checkpoint/restore pod tests are not running with an older runc and now
that runc 1.1.0 appears in the repositories it was detected that the
tests were failing. This was not detected in CI as CI was not using runc
1.1.0 yet.

Signed-off-by: Adrian Reber <[email protected]>
@lsm5 @mheon
enable netavark specific tests
22cfa98 
These are copies of the CNI tests with modifications wherever
neccessary.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@Foxboron @mheon
create: Fix key=value annotation in the flag output
f35e03e 
[NO NEW TESTS NEEDED]

Signed-off-by: Morten Linderud <[email protected]>
@Luap99 @mheon
podman network: add documentation for netavark
8ad2942 
Add some docs about the different network backends. Also remove the CNI
word from network since we refer to either a netavark or CNI config.

Signed-off-by: Paul Holzinger <[email protected]>
@vrothberg @mheon
e2e: merge after/since image-filter tests
77e51e1 
Merge the two tests to speed up testing.  Both built the exact same
images.

Signed-off-by: Valentin Rothberg <[email protected]>
@patrycja-guzik @mheon
Unify ls --filter docs for networks and pods
bd8ac00 
Signed-off-by: Patrycja Guzik <[email protected]>

containers#13078 follow-up
@n1hility @mheon
Update to podman4 copr stream
809da6b 
Signed-off-by: Jason T. Greene <[email protected]>
@esendjer @mheon
ignition: propagate proxy settings from a host into a vm
2128236 
Set proxy settings (such as `HTTP_PROXY`, and others)
for the whole guest OS with setting up `DefaultEnvironment`
with a `systemd` configuration file `default-env.conf`,
a `profile.d` scenario file - `default-env.sh` and
a `environment.d` configuration file `default-env.conf`

The **actual** environment variables are read by podman
at a start, then they are encrypted with base64 into
a single string and after are provided into a VM through
QEMU Firmware Configuration (fw_cfg) Device

Inside a VM a systemd service `envset-fwcfg.service`
reads the providead encrypted string from fw_cfg, decrypts
and then adds to the files
 - `/etc/systemd/system.conf.d/default-env.conf`
 - `/etc/profile.d/default-env.sh`
 - `/etc/environment.d/default-env.conf`
At the end this service execute  `systemctl daemon-reload`
to propagate new variables for systemd manager

[NO NEW TESTS NEEDED]

Closes containers#13168

Signed-off-by: esendjer <[email protected]>
@n1hility @mheon
Initial implementation of mac forwarding using a privileged docker so…
f71dfcb 
…ck claim helper

Signed-off-by: Jason T. Greene <[email protected]>
@n1hility @mheon
Introduce podman machine init --root=t|f and podman machine set --roo…
1a8c715 
…t=t|f

Switch default to rootless for mac and windows

Signed-off-by: Jason T. Greene <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2022
@mheon
Copy link
Member Author

mheon commented Feb 16, 2022

Failures are real. It's related to the minimum API version bump to v4.0.0, and it's somewhere in the manifest endpoints. Tests look sane, code is suspicious - https://github.com/containers/podman/blob/main/pkg/bindings/manifests/manifests.go#L110 references API versions under v4.0?

Will continue looking but I am not an expert on this part of the code

@jwhonce PTAL

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Feb 17, 2022 •
edited
Loading

I suspect it has to do with the wrapper to support v3.x with 4.x libpod. My brain is too fried however. I've pinged @jwhonce @flouthoc and @Luap99 to PTAL

8a7e709#diff-044d310f157316ea3de231effda8f6822c587dd263482131fc09b6a2c12b0ddaR167

flouthoc
flouthoc reviewed Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomSweeneyRedHat I am not a lot familiar with recent changes that went into manifests list operations API, I think @jwhonce can tell this better but here is what i think is causing the issues.

With operations for service version greater than or equal to 4.0.0 now libpod uses a common PUT to /manifests with operation selected in payload and new flow calls func ManifestModify( in the end.

I think there might be issue in the way we are handling error here https://github.com/containers/podman/blob/main/pkg/api/handlers/libpod/manifests.go#L399.
It could use utils.Error( to write error as it looks like in some cases error is being returned correctly but for some cases it is not writing error payload and also ignoring actual status.

But this is just my suspect I'm sure @jwhonce can tell this better.

@cevich cevich mentioned this pull request Feb 17, 2022
Merged
@rhatdan
Copy link
Member

rhatdan commented Feb 17, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022
jwhonce and others added 5 commits February 17, 2022 12:34
@jwhonce @mheon
Fix manifest 4.0 Endpoints
ae9ad41 
Branch forced 4.0 only endpoints

Signed-off-by: Jhon Honce <[email protected]>
@mheon
Fix lint
15cb918 
Signed-off-by: Matthew Heon <[email protected]>
@mheon
Release notes for v4.0.0 final
84c8870 
Signed-off-by: Matthew Heon <[email protected]>
@mheon
Bump to v4.0.0
49f8da7 
Signed-off-by: Matthew Heon <[email protected]>
@mheon
Bump to v4.0.1-dev
d59749d 
Signed-off-by: Matthew Heon <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022
@mheon
Copy link
Member Author

mheon commented Feb 17, 2022

Repushed with Jhon's fixes included

@rhatdan
Copy link
Member

rhatdan commented Feb 17, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022
@mheon
Copy link
Member Author

mheon commented Feb 17, 2022

Two flakes. Rerunning.

@mheon
Copy link
Member Author

mheon commented Feb 17, 2022

Looks like tests are going to pass

@mheon
Copy link
Member Author

mheon commented Feb 17, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit 93e8c39 into containers:v4.0 Feb 17, 2022
@edsantiago edsantiago mentioned this pull request Feb 24, 2022
Closed
@edsantiago edsantiago mentioned this pull request Apr 28, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flouthoc flouthoc flouthoc left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.