Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create: Fix key=value annotation in the flag output #13223

Merged
merged 1 commit into from
Feb 14, 2022
Merged

create: Fix key=value annotation in the flag output #13223

merged 1 commit into from
Feb 14, 2022

Conversation

Foxboron
Copy link
Contributor

Signed-off-by: Morten Linderud [email protected]

@mheon
Copy link
Member

mheon commented Feb 12, 2022

LGTM, but please add [CI:DOCS] to your PR title and re-push to fix CI.

@Foxboron Foxboron changed the title create: Fix key=value annotation in the flag output [CI:DOCS] create: Fix key=value annotation in the flag output Feb 14, 2022
@rhatdan
Copy link
Member

rhatdan commented Feb 14, 2022

Thanks @Foxboron
Please sign your commits and add
[NO NEW TESTS NEEDED]
Also remove [CI:DOCS] since this is actually a change to code.

@Foxboron
create: Fix key=value annotation in the flag output
a0991c6 
[NO NEW TESTS NEEDED]

Signed-off-by: Morten Linderud <[email protected]>
@Foxboron Foxboron force-pushed the morten/fix-annotation branch from 4a0d577 to a0991c6 Compare February 14, 2022 14:42
@Foxboron Foxboron changed the title [CI:DOCS] create: Fix key=value annotation in the flag output create: Fix key=value annotation in the flag output Feb 14, 2022
@Foxboron
Copy link
Contributor Author

Done

@rhatdan
Copy link
Member

rhatdan commented Feb 14, 2022

LGTM
@containers/podman-maintainers PTAL

@ashley-cui
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2022
@rhatdan
Copy link
Member

rhatdan commented Feb 14, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Foxboron, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit 38b19c1 into containers:main Feb 14, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ashley-cui ashley-cui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Foxboron @mheon @rhatdan @ashley-cui @openshift-merge-robot