COPR: fix dependencies #13105
COPR: fix dependencies #13105
Conversation
openshift-ci
bot
added
the
approved
containers-common rpm now `Recommends: netavark` and `Provides: container-network-stack` which are actually provided by both cni-plugins and netavark. Netavark has a `Recommends: aardvark-dns` already. So, we should only depend on the containers-common package and let it handle everything. Also, dnsname no longer needs to be recommended if we want new users to use netavark / aardvark-dns. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
copr-fix-dependencies
branch
from
22109f0 to
cd8b302
Compare
|
LGTM |
|
/approve |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| # containers-common pulled from podman-next copr for f34, | ||
| # from the distro repos for f35+ | ||
| %if 0%{?fedora} <= 35 | ||
| Requires: containers-common >= 4:1-39 |
There was a problem hiding this comment.
The last bodhi I see for fc35 is -36 and it's not even in repos yet; for fc34 it's -21. Won't this make the package uninstallable?
There was a problem hiding this comment.
@edsantiago RE: f34, I sent a containers-common to the podman-next copr. https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/build/3289552/ . Also, for f35, there's -39 at https://bodhi.fedoraproject.org/updates/FEDORA-2022-0afb41b09c which got struck down. But it should still work ok with non-moby users.
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
containers-common rpm now
Recommends: netavarkandProvides: container-network-stackwhich areactually provided by both cni-plugins and netavark.
Netavark has a
Recommends: aardvark-dnsalready.So, we should only depend on the containers-common package and let it
handle everything.
Also, dnsname no longer needs to be recommended if we want new users to
use netavark / aardvark-dns.
[NO NEW TESTS NEEDED]
Signed-off-by: Lokesh Mandvekar [email protected]
@cevich @rhatdan @mheon @baude @edsantiago PTAL
/cc @containers/podman-maintainers