libpod: report slirp4netns network stats #13101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
giuseppe
force-pushed
the
report-slirp4netns-stats
branch
from
864dae4 to
66add34
Compare
Luap99
reviewed
Feb 1, 2022
There was a problem hiding this comment.
LGTM but we still have to fix the other cases I mentioned in the issue.
- We should not hardcode eth0 and instead read the interface name from the network status
- How do we handle multiple interfaces? Should we add stats together?
- For slirp4netns with rootlessport forwarder the traffic send via the port forwarding will not be counted on the tap0 interface. You can only see it on the loopback interface. (This should be at least documented.)
by default slirp4netns uses the tap0 device. When slirp4netns is used, use that device by default instead of eth0. Closes: containers#11695 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
report-slirp4netns-stats
branch
from
66add34 to
865f0a1
Compare
Yes, I think we need to read all the devices available and add stats together.
Good point. Added a note to the documentation |
Luap99
reviewed
Feb 1, 2022
| @@ -98,6 +98,10 @@ ID NAME MEM USAGE / LIMIT | |||
| 6eae9e25a564 clever_bassi 3.031MB / 16.7GB | |||
| ``` | |||
|
|
|||
| Note: When using a slirp4netns network, the traffic send via the port forwarding will be accounted | |||
There was a problem hiding this comment.
you should mention the rootlesskit port handler, with --network slirp4netns:port_handler=slirp4netns it should be counted correctly on tap0 AFAIK
|
I am going to merge, and @giuseppe can address the other requests in a separate PR. Do not want to miss getting this into 4.0. |
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Feb 1, 2022
follow-up for containers#13101 [CI:DOCS] Signed-off-by: Giuseppe Scrivano <[email protected]>
mheon
pushed a commit
to mheon/libpod
that referenced
this pull request
Feb 3, 2022
follow-up for containers#13101 [CI:DOCS] Signed-off-by: Giuseppe Scrivano <[email protected]>
patrycja-guzik
pushed a commit
to patrycja-guzik/podman
that referenced
this pull request
Feb 15, 2022
follow-up for containers#13101 [CI:DOCS] Signed-off-by: Giuseppe Scrivano <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by default slirp4netns uses the tap0 device. When slirp4netns is
used, use that device by default instead of eth0.
Closes: #11695
Signed-off-by: Giuseppe Scrivano [email protected]