Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Add notes to "--oom-kill-disable" not supported on cgroups V2 #13100

Merged

Conversation

ttsuuubasa
Copy link
Contributor

Clarify "--oom-kill-disable" is not supported on cgroups V2 in documentation.

podman on crun and cgroups V2 gets the error as following when executing "podman run --oom-kill-disable=true".

# podman run --oom-kill-disable=true -d fedora sleep 300
Error: OCI runtime error: crun: cannot disable OOM killer with cgroupv2

podman version

# podman -v
podman version 4.0.0-dev

crun version

# podman info --format json | jq -r .host.ociRuntime.package
crun-1.4.1-1.fc34.x86_64

Signed-off-by: Tsubasa Watanabe [email protected]

Clarify "--oom-kill-disable" is not supported on cgroups V2 in
documentation.

Signed-off-by: Tsubasa Watanabe <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Feb 1, 2022

LGTM
Want to hear feedback from @giuseppe

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe
Copy link
Member

giuseppe commented Feb 1, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fj-tsubasa, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit 905d31d into containers:main Feb 1, 2022
@@ -739,6 +739,8 @@ This option conflicts with **--add-host**.

Whether to disable OOM Killer for the container or not.

This flag is not supported on cgroups V2 systems.
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be cgroup, but after looking at the doc, we have both cgroup and cgroups all over the place.

@ttsuuubasa ttsuuubasa deleted the oom-kill-disable-man branch February 3, 2022 01:26
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants