I believe that these tests will now run with crun.

[rhatdan]

Signed-off-by: Daniel J Walsh [email protected]

[rhatdan]

@adrianreber @giuseppe These are still broken on crun?

[adrianreber]

@adrianreber @giuseppe These are still broken on crun?

Yes, the PR to fix it is open but I am waiting for CRIU PRs to merge and then we also need a CRIU release for the crun changes to work.

This cannot work yet in Podman.

[rhatdan]

@giuseppe Any movement on this?

[giuseppe]

the changes are already included in a crun release

[rhatdan]

@cevich @giuseppe Does this mean we need a new crun in the test VMs.

[cevich]

a crun release

Any idea of the version number of the package?

[giuseppe]

Any idea of the version number of the package?

1.4.2 has all the changes we need in Podman

[adrianreber]

CRIU 3.17 is not yet released, so this will not yet work. Once 3.17 is released crun needs to be rebuilt and then Podman can use crun for these tests.

[cevich]

Thanks for the info guys. Someone please just @mention me once CRIU & crun are available at least in the updates-testing channel for Fedora (probably F36 I'm guessing).

[vrothberg]

Release is still pending.

[baude]

@rhatdan @adrianreber do we want this in 4.1?

[rhatdan]

No this is just adding tests, which should work on latest runc, problem is latest runc is not released to ubuntu.

[cevich]

latest runc is not released to ubuntu.

😞 our ubuntu images are out of date. They need bumping up to 22.04 - which probably has newer versions.

[rhatdan]

@cevich Are you going to make this happen?

[cevich]

@cevich Are you going to make this happen?

Thanks for reminding me. I'm currently loaded up with this AWS stuff, and it would be useful and good test of the docs to see if someone else can do it. I realize that's probably a big ask. Let me craft an e-mail and see if anyone bites (unless you have a better idea).

[cevich]

@lsm5 FYI - this PR is driving the need for new images (including Ubuntu).

[lsm5]

new ubuntu happening at containers/automation_images#134

[vrothberg]

Are we ready to go?

[cevich]

It would be informative to try this PR with the updated image ID in #14397 Though there is currently an outstanding issue with the Ubuntu VMs, the Fedora ones should work. So if they fail for this PR, it could be an indicator runc-1.1.1-1.fc36 still isn't new enough (I'm guessing).

[rhatdan]

@cevich it was my understanding that the issue here is with crun not runc.

[cevich]

the issue here is with crun not runc.

Before you commented:

No this is just adding tests, which should work on latest runc, problem is latest runc is not released to ubuntu.

In any case, you might try rebasing onto #14397 as it has updated images all around. Looks like:

• F35: crun-1.4.5-1.fc35-x86_64 and runc-1.1.1-1.fc35-x86_64
• F36: crun-1.4.5-1.fc36-x86_64 and runc-1.1.1-1.fc36-x86_64
• U21104: crun-1.4.5-0ubuntu22.04+obs31.1-amd64 and runc-1.1.0-0ubuntu1-amd64

[rhatdan]

Miracle of Miracle, this finally past tests. Only started on this back in January 14

@giuseppe @cevich @edsantiago @vrothberg PTAL
@containers/podman-maintainers PTAL

[giuseppe]

LGTM

[flouthoc]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [flouthoc,giuseppe,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[giuseppe]

/lgtm

[vrothberg]

Congrats on getting it in 🥳