Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IndexConfigs info to compat /info endpoint #12862

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Add IndexConfigs info to compat /info endpoint #12862

merged 1 commit into from
Jan 19, 2022

Conversation

matejvasek
Copy link
Contributor

resolves #12551

@matejvasek
Copy link
Contributor Author

/cc @jwhonce

@openshift-ci openshift-ci bot requested a review from jwhonce January 14, 2022 16:16
@rhatdan
Copy link
Member

rhatdan commented Jan 14, 2022

LGTM

vrothberg
vrothberg reviewed Jan 17, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

One nit and the ask to add commit messages. "improve $item" is not enough to know what was going on in the future.

pkg/api/handlers/compat/info.go Outdated Show resolved Hide resolved
@rhatdan
Copy link
Member

rhatdan commented Jan 17, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2022
@jwhonce
Copy link
Member

jwhonce commented Jan 18, 2022

@matejvasek LGTM and will merge once conflict has been resolved. Thanks!

@rhatdan
Copy link
Member

rhatdan commented Jan 18, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@vrothberg
Copy link
Member

One nit and the ask to add commit messages. "improve $item" is not enough to know what was going on in the future.

That still remains. Let's keep our git history in a way that future readers can understand what happened.

@matejvasek matejvasek changed the title Improve compat /info endpoint Add IndexConfigs info to compat /info endpoint Jan 19, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2022
@matejvasek
Copy link
Contributor Author

@rhatdan I just changed commit message please re-lgtm.

@mheon
Copy link
Member

mheon commented Jan 19, 2022

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8301a7c into containers:main Jan 19, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhangguanzhang zhangguanzhang zhangguanzhang left review comments

@vrothberg vrothberg vrothberg left review comments

@jwhonce jwhonce Awaiting requested review from jwhonce

Assignees

@rhatdan rhatdan

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Docker APIv2 /info endpoint doesn't return sufficient info with regard to registries
7 participants
@matejvasek @rhatdan @jwhonce @vrothberg @mheon @zhangguanzhang @openshift-merge-robot