Use CONTAINERS_CONF cgroups flag for remote API. #12860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Fixed: #12550 |
|
I got a bit worried about the diffstat, but CGroup -> Cgroup makes sense to me |
|
Yes I went both ways and this seems least breaking. |
Signed-off-by: Daniel J Walsh <[email protected]>
Also change code to globably be consistent when refering to capatilized Cgroup. Fixed: containers#12550 Signed-off-by: Daniel J Walsh <[email protected]>
|
@containers/podman-maintainers PTAL |
|
LGTM |
vrothberg
reviewed
Jan 17, 2022
| inspect.WaitWithDefaultTimeout() | ||
| Expect(inspect.OutputToString()).To(Not(Equal("disabled"))) | ||
|
|
||
| os.Setenv("CONTAINERS_CONF", conffile) |
There was a problem hiding this comment.
Not needed in containers_conf_test. The Before/After are taking care of this.
vrothberg
reviewed
Jan 17, 2022
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.