libpod: drop check for empty pod cgroup #12828
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
|
We should be retaining this check, but ensuring that UsePodCgroup is not set for cases where the pod can't share its cgroup. |
rootless containers do not use cgroups on cgroupv1 or if using cgroupfs, so improve the check to account for such configuration. Closes: containers#10800 Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2028243 [NO NEW TESTS NEEDED] it requires rebooting and the rundir on a non tmpfs file system. Signed-off-by: Giuseppe Scrivano <[email protected]>
pushed a new version |
|
@umohnani8 could you check if the last version still work fine with your reproducer? |
|
LGTM |
1 similar comment
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
Tested the patch and it fixes the problem. |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
rootless containers do not use cgroups on cgroupv1 or if using
cgroupfs, so drop the redundant check for an empty pod cgroup.
Closes: #10800
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2028243
[NO NEW TESTS NEEDED] it requires rebooting and the rundir on a non
tmpfs file system.
Signed-off-by: Giuseppe Scrivano [email protected]