api: remove use of deprecated/removed constants for CNI from buildah
#12822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
flouthoc
changed the title
CNI from buildah
2 tasks
|
@Luap99 Could you PTAL. I think some essentials are removed from buildah as part of refactor. |
Following PR allows vendoring in latest buildah. Since some of the essential constants were removed from buildah hence they cannot be used any more. Use `c/common` instead. Constants were removed in following PR: containers/buildah#3697 [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <[email protected]>
flouthoc
force-pushed
the
fix-cni-common-vendor
branch
from
5fa7f00 to
2c51c92
Compare
|
I will take care of it in #12642, buildah is still failing tests without containers/buildah#3698 |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR allows vendoring in latest buildah. Since some of the
essential constants were removed from buildah hence they cannot be
used any more. Use
c/commoninstead.Constants were removed in following PR: containers/buildah#3697
Unblocks buildah vendoring.
[NO NEW TESTS NEEDED]