Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendoring in buildah,common, image #12794

Closed
wants to merge 1 commit into from
Closed

Update vendoring in buildah,common, image #12794

wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 10, 2022

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022
@rhatdan
Copy link
Member Author

rhatdan commented Jan 10, 2022

@giuseppe something is awry in containers/storage.

@giuseppe giuseppe mentioned this pull request Jan 11, 2022
Closed
@rhatdan
Copy link
Member Author

rhatdan commented Jan 11, 2022

We are stuck waiting for a zstd PR, which needs to then get merged into containers/storage and then out to here.

@rhatdan
Copy link
Member Author

rhatdan commented Jan 11, 2022

valyala/gozstd#41

@rhatdan rhatdan changed the title Update vendoring in buildah,common, image and storage Update vendoring in buildah,common, image Jan 11, 2022
@rhatdan
Update vendoring in buildah,common, image
2adb9ff 
[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <[email protected]>
vrothberg
vrothberg reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@vrothberg
Copy link
Member

[+0048s] # ERROR: for app (<Service: app>, 'error creating build container: error opening "/usr/local/libexec/cni/cni.lock": creating locker directory: mkdir /usr/local/libexec/cni: permission denied\n')

@Luap99
Copy link
Member

Luap99 commented Jan 12, 2022

You cannot update buildah, we first need containers/buildah#3698 to get merged and then I can rebase #12642 to vendor in buildah properly with the required network changes.

@rhatdan rhatdan closed this Jan 12, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhatdan @vrothberg @Luap99