Prevent double decoding of storage options #12767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You must sign your PR git commit -a --amend -s |
riyad
force-pushed
the
fix-storage-opt-double-decode
branch
from
e854ed8 to
826158c
Compare
|
signed ✔️ |
|
Should I also add |
|
Yes add [NO NEW TESTS NEEDED] |
[NO NEW TESTS NEEDED] see containers#11991 Signed-off-by: Riyad Preukschas <[email protected]>
riyad
force-pushed
the
fix-storage-opt-double-decode
branch
from
826158c to
7dada6d
Compare
|
added |
|
LGTM if this passes tests. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, riyad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage options are already being decoded in pkg/specgenutil/specgen.go:397.
Fixes #12766