add OCI Runtime name to errors #12758
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@mheon @edsantiago @giuseppe PTAL |
|
Tests are red. Approach LGTM. |
|
Tests are red because of #12759 |
It would be easier to diagnose OCI runtime errors if the error actually had the name of the OCI runtime that produced the error. [NO NEW TESTS NEEDED] Signed-off-by: Daniel J Walsh <[email protected]>
| err_no_such_cmd="Error:.*executable file.* not found in \$PATH: No such file or directory: OCI runtime attempted to invoke a command that was not found" | ||
| err_no_exec_dir="Error:.*open executable: Operation not permitted: OCI permission denied" |
There was a problem hiding this comment.
Why not include the crun: here?
- err_no_such_cmd="Error:.*executable file.* not found in \$PATH: No such file or directory: OCI runtime attempted to invoke a command that was not found"
- err_no_exec_dir="Error:.*open executable: Operation not permitted: OCI permission denied"
+ err_no_such_cmd="Error: crun: executable file.* not found in \$PATH: No such file or directory: OCI runtime attempted to invoke a command that was not found"
+ err_no_exec_dir="Error: crun: open executable: Operation not permitted: OCI permission denied"It seems like a perfect opportunity to confirm that the new code works as expected.
There was a problem hiding this comment.
Because if others run the tests using other runtimes, then it will blow up.
There was a problem hiding this comment.
Look at the line immediately above 😁
There was a problem hiding this comment.
It's OK. CI is green. I'll add this to my list of minor tweaks to bunch up and commit once in a while.
/lgtm
/hold
openshift-ci
bot
added
the
do-not-merge/hold
edsantiago
removed
the
do-not-merge/hold
Emergency fix to image-scp tests. DO NOT CREATE A USER! These tests are run in all sorts of environments. We do not have the right to vandalize a production system. Also remove some misleading unneeded tests; and refactor a little; and add a bunch of FIXMEs which will need to be addressed later. Also, super-low priority, add 'crun: ' to expected error message in a run test (minor followup to containers#12758). Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
It would be easier to diagnose OCI runtime errors if the error actually
had the name of the OCI runtime that produced the error.
[NO NEW TESTS NEEDED]
Signed-off-by: Daniel J Walsh [email protected]