Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] fix doc typo #12731

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Conversation

junnplus
Copy link
Contributor

@junnplus junnplus commented Jan 3, 2022

Signed-off-by: ye.sijun [email protected]

Signed-off-by: ye.sijun <[email protected]>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2022
@flouthoc
Copy link
Collaborator

flouthoc commented Jan 3, 2022

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, Junnplus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit 172d4eb into containers:main Jan 3, 2022
@Luap99
Copy link
Member

Luap99 commented Jan 3, 2022

@junnplus Thanks, can you add the same change to https://github.com/containers/common/blob/38000f636f08e6362584c547ffb908dbaa22c8a5/libnetwork/internal/util/util.go#L81-L82
The code was moved to the c/common repo, #12642 will remove this code from podman

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants