Revamp Libpod state strings for Docker compat

[mheon]

Improve our compatibility with Docker by better handling the state strings that we print in podman ps. Docker capitalizes all states in ps (we do not) - fix this in our PS code. Also, stop normalizing ContainerStateConfigured to the "Created" state, and instead make it always be Created, with the existing Created state becoming Initialized.

I didn't rename the actual states because I'm somewhat reticent to make such a large change a day before we leave for break. It's somewhat confusing that ContainerStateConfigured now returns Created, but internally and externally we're still consistent.

[NO NEW TESTS NEEDED] existing tests should catch anything that broke.

I also consider this a breaking change. I will flag appropriately on Github.

Fixes RHBZ#2010432 and RHBZ#2032561

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

I fully expect tests will be red initially, will fix whatever this breaks once I know what that happens to be.

[rhatdan]

LGTM

[mheon]

I think I have the tests sorted now

[TomSweeneyRedHat]

@mheon, I think you needed to cross your fingers tighter on the test wish, a lot of red there.
Will these changes cause any upgrade issues?

[mheon]

Potentially? This is a frequently machine-parsed field and we're making significant changes to it. The breaking-change label is there for that reason.

[mheon]

I might need help from @edsantiago on the system tests, which means they might have to wait until after Christmas break. I think the original failure is definitely in not ok 72 podman ps --external but it's not obvious to me what is actually going wrong.

[edsantiago]

Looks like lower-case storage got changed to capitalized Storage?

[edsantiago]

This seems to fix things, but I'm concerned, first because why did these things change, and second, tests seem to be running reeeeeally slowly. I can't take the time to look into it further right now.

diff --git a/test/system/040-ps.bats b/test/system/040-ps.bats
index 61b290415..8d0a405d2 100644
--- a/test/system/040-ps.bats
+++ b/test/system/040-ps.bats
@@ -110,7 +110,7 @@ EOF
     run_podman ps --external
     is "${#lines[@]}" "3" "podman ps -a --external sees buildah containers"
     is "${lines[1]}" \
-       "[0-9a-f]\{12\} \+$IMAGE *buildah .* seconds ago .* storage .* ${PODMAN_TEST_IMAGE_NAME}-working-container" \
+       "[0-9a-f]\{12\} \+$IMAGE *buildah .* seconds ago .* Storage .* ${PODMAN_TEST_IMAGE_NAME}-working-container" \
        "podman ps --external"

     # 'rm -a' should be a NOP
diff --git a/test/system/080-pause.bats b/test/system/080-pause.bats
index 857c8bbf4..4d9b7f889 100644
--- a/test/system/080-pause.bats
+++ b/test/system/080-pause.bats
@@ -26,7 +26,7 @@ load helpers
     is "$output" "paused" "podman inspect .State.Status"
     sleep 3
     run_podman ps -a --format '{{.ID}} {{.Names}} {{.Status}}'
-    is "$output" "${cid:0:12} $cname paused" "podman ps on paused container"
+    is "$output" "${cid:0:12} $cname Paused" "podman ps on paused container"
     run_podman unpause $cname
     run_podman ps -a --format '{{.ID}} {{.Names}} {{.Status}}'
     is "$output" "${cid:0:12} $cname Up .*" "podman ps on resumed container"

[mheon]

The paused vs Paused change is expected. The storage vs Storage was not, but looking at it, I can see how it happened. I think it's probably OK to leave it.

[edsantiago]

Ack, thanks. But there are more problems: generate systemd tests are failing too. Again, I don't have time now to look into it deeper, sorry.

[Luap99]

@mheon friendly ping, since this is a breaking change we need should this before 4.0

[mheon]

Wait, this didn't land yet? Thought it merged before break.

I'll try and get it landed today.

[mheon]

Repushed, I think I got the last test

[mheon]

@containers/podman-maintainers PTAL, this is going green

[edsantiago]

LGTM. I no longer remember what the problem was with the systemd tests, so, this has my blessing. I'd like someone more docker-experienced to give the final approval though.

[rhatdan]

/lgtm