Error out early if system does not support pre-copy checkpointing #12672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Tests aren't happy. Couple doc nits, otherwise LGTM |
adrianreber
force-pushed
the
2021-12-21-check-for-memtrack
branch
3 times, most recently
from
e7c9869 to
9f788fd
Compare
|
I think this was Quay hiccuping - restarted |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianreber, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mheon
reviewed
Dec 22, 2021
|
One nit otherwise LGTM |
adrianreber
force-pushed
the
2021-12-21-check-for-memtrack
branch
from
9f788fd to
9a8794d
Compare
|
@adrianreber Needs a rebase. |
Signed-off-by: Adrian Reber <[email protected]>
CRIU's pre-copy migration support relies on the soft dirty page tracking in the Linux kernel: https://www.kernel.org/doc/Documentation/vm/soft-dirty.txt This functionality is not implemented for all architectures and it can also be turned off in the kernel. CRIU can check if the combination of architecture/kernel/CRIU supports the soft dirty page tracking and exports this feature checking functionality in go-criu. This commit adds an early check if the user selects pre-copy checkpointing to error out if the system does not support it. Signed-off-by: Adrian Reber <[email protected]>
adrianreber
force-pushed
the
2021-12-21-check-for-memtrack
branch
from
9a8794d to
d669dbf
Compare
|
Rebased |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRIU's pre-copy migration support relies on the soft dirty page tracking in the Linux kernel:
https://www.kernel.org/doc/Documentation/vm/soft-dirty.txt
This functionality is not implemented for all architectures and it can also be turned off in the kernel.
CRIU can check if the combination of architecture/kernel/CRIU supports the soft dirty page tracking and exports this feature checking functionality in go-criu.
This commit adds an early check if the user selects pre-copy checkpointing to error out if the system does not support it.