Podman run --passwd #12664
Podman run --passwd #12664
Conversation
cdoern
force-pushed
the
noManagePasswd
branch
3 times, most recently
from
a147298 to
99d8639
Compare
|
@containers/podman-maintainers PTAL |
|
/approve |
openshift-ci
bot
added
the
approved
cdoern
force-pushed
the
noManagePasswd
branch
from
99d8639 to
ac5df80
Compare
libpod/container_config.go
Outdated
| @@ -163,6 +163,8 @@ type ContainerRootFSConfig struct { | |||
| // Volatile specifies whether the container storage can be optimized | |||
| // at the cost of not syncing all the dirty files in memory. | |||
| Volatile bool `json:"volatile,omitempty"` | |||
| // ManagePasswd allows to user to override podman's passwd/group file setup | |||
| ManagePasswd bool `json:"manage_password,omitempty"` | |||
There was a problem hiding this comment.
Why ManagePasswd as opposed to Passwd?
There was a problem hiding this comment.
I thought it was more descriptive than just passwrd especially in the config, I can change it back if you disagree.
There was a problem hiding this comment.
yep, just realized I did not add a way to see this in inspect, I will add that now
|
Tests are very red. A couple of small man page nits. |
cdoern
force-pushed
the
noManagePasswd
branch
from
ac5df80 to
78b2882
Compare
|
I think it would be better all throughout to just call it passwd. I think the manage_passwd, ManagePasswd ... just confuses the PR. |
added support for a new flag --passwd which, when false prohibits podman from creating entries in /etc/passwd and /etc/groups allowing users to modify those files in the container entrypoint resolves containers#11805 Signed-off-by: cdoern <[email protected]>
cdoern
force-pushed
the
noManagePasswd
branch
from
78b2882 to
20ce6e5
Compare
|
/approve |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
| // If it already exists, delete so we can recreate | ||
| delete(c.state.BindMounts, "/etc/group") | ||
| c.state.BindMounts["/etc/group"] = newGroup | ||
| if c.config.Passwd != nil && *c.config.Passwd { |
There was a problem hiding this comment.
Nit: this is going to break existing containers - if it is nil we have to run this code.
There was a problem hiding this comment.
Thanks, sorry I missed that.
github-actions
bot
added
the
locked - please file new issue/PR
added support for a new flag --passwd which, when false, prohibits podman from creating entries in
/etc/passwd and /etc/groups allowing users to modify those files in the container entrypoint
resolves #11805
Signed-off-by: cdoern [email protected]