remote events: convert TimeNano properly

[leahneukirchen]

e.TimeNano contains nanoseconds since epoch, not just the nanoseconds
after e.Time.

time.Unix supports nanoseconds > 999999999 and converts them to seconds,
so just passing e.TimeNano is enough.

Closes #12629.

[mheon]

PR is complaining about a lack of test coverage. You can look into adding a test (maybe check that the year in the timestamp matches the current year?) or just add [NO NEW TESTS NEEDED] to your commit message and force-push.

[mheon]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leahneukirchen, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[leahneukirchen]

Note that it only affects remote events, I'm not sure where this can be tested.

[rhatdan]

Thanks @leahneukirchen
LGTM
I guess you could add a test to make sure the year reported in podman events is this century. :^)
Or just add [NO NEW TESTS NEEDED]

[Luap99]

Maybe add a test here:

podman/test/e2e/events_test.go

Line 64 in f45070e

Expect(len(result.OutputToStringArray())).To(BeNumerically(">=", 1), "Number of events")

I think this should work:

diff --git a/test/e2e/events_test.go b/test/e2e/events_test.go
index 39f495460..0350bf93c 100644
--- a/test/e2e/events_test.go
+++ b/test/e2e/events_test.go
@@ -62,6 +62,8 @@ var _ = Describe("Podman events", func() {
                result.WaitWithDefaultTimeout()
                Expect(result).Should(Exit(0))
                Expect(len(result.OutputToStringArray())).To(BeNumerically(">=", 1), "Number of events")
+               date := time.Now().Format("2000-01-01")
+               Expect(result.OutputToStringArray()).To(ConsistOf(HavePrefix(date)))
        })
 
        It("podman events with an event filter and container=cid", func() {
``´

[leahneukirchen]

I think this test suite doesn't test for --remote, however.

[mheon]

It will, we have several suites for the remote client (Any of the tests marked int remote run the integration tests with the remote client using the specified OS - looks like we have F34, F35, and Ubuntu 21.10 enabled).

[leahneukirchen]

Ok, I can add this then. Give me a few days, tho.

[rhatdan]

@leahneukirchen friendly ping

[leahneukirchen]

There only seems to be a way to test one log line to have the right prefix, but I guess that works too.

[rhatdan]

LGTM
Thanks @leahneukirchen

[leahneukirchen]

These failures are unrelated I think?

[mheon]

Restarted, if they're still red in a few hours I'll look deeper and see if they're related

[vrothberg]

@leahneukirchen, could you do another rebase? CI should be green now. Apologies!

[Luap99]

/lgtm