Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --ip6 flag to podman create/run #12611

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Dec 15, 2021

What this PR does / why we need it:

Add the --ipv6 flag to podman create/run and pod create. We support the
--network name:ip6=<ip> syntax now but for docker compat we should also
support the --ip6 flag.
Note that there is no validation if the ip is actually a v6 or v4 address
because the backend does not care either.

How to verify it

Which issue(s) this PR fixes:

Fixes #7511

Special notes for your reviewer:

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@vikas-goel
Copy link
Contributor

If this PR is enabling static IPv6 support, will be good to update podman create/run man pages too.
Will it enable static IPv6 support for macvlan networks?

@TomSweeneyRedHat
Copy link
Member

All kinds of test unhappiness. Code generally LGTM

@Luap99
Copy link
Member Author

Luap99 commented Dec 16, 2021

@vikas-goel static ipv6 support was added in #12534
This PR just adds the --ip6 flag. The docs are also updated.

@Luap99
Copy link
Member Author

Luap99 commented Dec 16, 2021

@vikas-goel Macvlan should work too, that might depend if CNI supports this but it will definitely work with the new network stack netavark.

Add the --ipv6 flag to podman create/run and pod create. We support the
--network name:ip6=<ip> syntax now but for docker compat we should also
support the --ip6 flag.
Note that there is no validation if the ip is actually a v6 or v4 address
because the backend does not care either.

Fixes containers#7511

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
Copy link
Member Author

Luap99 commented Jan 3, 2022

@containers/podman-maintainers PTAL

@rhatdan
Copy link
Member

rhatdan commented Jan 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit aaf90c5 into containers:main Jan 3, 2022
@Luap99 Luap99 deleted the ipv6 branch January 3, 2022 17:49
@vikas-goel
Copy link
Contributor

When will 4.0 be released?

@vikas-goel
Copy link
Contributor

When will podman static IPv6 be included in RHEL8?

@Luap99
Copy link
Member Author

Luap99 commented Jan 4, 2022

I think the goal is to release 4.0 in February and to get it into RHEL 8.6/9.0

@vikas-goel
Copy link
Contributor

Thank you @Luap99. Did you mean both RHEL 8.6 and 9.0?

@rhatdan
Copy link
Member

rhatdan commented Jan 5, 2022

That is a goal, but we could definitely miss it and it would be RHEL 8.6.0.2 and 9.0.0.2

@vikas-goel
Copy link
Contributor

Thank you @rhatdan

edsantiago added a commit to edsantiago/libpod that referenced this pull request Sep 13, 2022
Between podman-create, run, and pod-create. The big difference
is that I changed 'IP' to 'IPv4' in podman-pod-create, I believe
that was an oversight in containers#12611.

Signed-off-by: Ed Santiago <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static IPv6 address and --ip6
5 participants