-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --ip6 flag to podman create/run #12611
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If this PR is enabling static IPv6 support, will be good to update podman create/run man pages too. |
All kinds of test unhappiness. Code generally LGTM |
@vikas-goel static ipv6 support was added in #12534 |
@vikas-goel Macvlan should work too, that might depend if CNI supports this but it will definitely work with the new network stack netavark. |
Add the --ipv6 flag to podman create/run and pod create. We support the --network name:ip6=<ip> syntax now but for docker compat we should also support the --ip6 flag. Note that there is no validation if the ip is actually a v6 or v4 address because the backend does not care either. Fixes containers#7511 Signed-off-by: Paul Holzinger <[email protected]>
@containers/podman-maintainers PTAL |
/lgtm |
When will 4.0 be released? |
When will podman static IPv6 be included in RHEL8? |
I think the goal is to release 4.0 in February and to get it into RHEL 8.6/9.0 |
Thank you @Luap99. Did you mean both RHEL 8.6 and 9.0? |
That is a goal, but we could definitely miss it and it would be RHEL 8.6.0.2 and 9.0.0.2 |
Thank you @rhatdan |
Between podman-create, run, and pod-create. The big difference is that I changed 'IP' to 'IPv4' in podman-pod-create, I believe that was an oversight in containers#12611. Signed-off-by: Ed Santiago <[email protected]>
What this PR does / why we need it:
Add the --ipv6 flag to podman create/run and pod create. We support the
--network name:ip6=<ip>
syntax now but for docker compat we should alsosupport the --ip6 flag.
Note that there is no validation if the ip is actually a v6 or v4 address
because the backend does not care either.
How to verify it
Which issue(s) this PR fixes:
Fixes #7511
Special notes for your reviewer: