Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set machine timezone #12609

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Set machine timezone #12609

merged 1 commit into from
Dec 16, 2021

Conversation

baude
Copy link
Member

@baude baude commented Dec 15, 2021

Added an option to podman machine init to declare the timezone of the
resulting machine. the default is to use the value of the host name or
else a given timezone name like America/Chicago.

Fixes: #11895

Signed-off-by: Brent Baude [email protected]

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@TomSweeneyRedHat
Copy link
Member

LGTM
once the tests right themselves

@rhatdan
Copy link
Member

rhatdan commented Dec 16, 2021

What about windows?

Added an option to podman machine init to declare the timezone of the
resulting machine.  the default is to use the value of the host name or
else a given timezone name like America/Chicago.

Fixes: containers#11895

Signed-off-by: Brent Baude <[email protected]>

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@baude
Copy link
Member Author

baude commented Dec 16, 2021

What about windows?

there is no podman machine on windows

@rhatdan
Copy link
Member

rhatdan commented Dec 16, 2021

Does WSL automatically change to match host?

@rhatdan
Copy link
Member

rhatdan commented Dec 16, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 52d5f36 into containers:main Dec 16, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure when using the -tz flag or setting tz in containers conf on macos
4 participants