bindings rmi test: clarify behavior #12606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Luap99
reviewed
Dec 15, 2021
|
Changes look OK to me, but the tests aren't at all happy. |
search on registry.access.redhat.com/* is broken. All tests in all PRs are red at the moment :^) |
|
LGTM |
|
rebased to fix the search flake ✔️ |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
Unintended consequences |
vrothberg
commented
Dec 16, 2021
The libpod/images/remove endpoint is not very REST-ish but, after some debate, was decided to be implemented as for the following reasons. First, it allows for batch removing images which improves performance significantly. Note that Docker does support `rmi -a`! Second, it allows for hiding the logic of setting the right exit code to use from the client and keep all the logic on the server. Hence, when removing an image that does not exist, the server will return a 200. The response, however, includes the error message to be used *and* the exit code that podman-remote will use. Fixes: containers#12441 Signed-off-by: Valentin Rothberg <[email protected]>
|
ready to merge |
|
/lgtm |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libpod/images/remove endpoint is not very REST-ish but, after some
debate, was decided for it to be implemented as is for the following reasons.
First, it allows for batch removing images which improves performance
significantly. Note that Docker does support
rmi -a!Second, it allows for hiding the logic of setting the right exit code to
use from the client and keep all the logic on the server.
Hence, when removing an image that does not exist, the server will
return a 200. The response, however, includes the error message to be
used and the exit code that podman-remote will use.
Fixes: #12441
Signed-off-by: Valentin Rothberg [email protected]
@edsantiago PTAL