-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #11089] Switch to a new installer approach using a path manipulation helper #12597
Conversation
@ashley-cui @jwhonce @baude PTAL |
BTW I forgot to mention in case it comes up. The reason this was done as a separate executable as opposed to podman subcommand is to be able to compile it as a GUI application and get rid of the console that splashes and vanishes immediately after during installation. If we decide we do not want to leave the helper executable on the user FS, we can also embed it as a binary element in the installer (config change + switch to path param approach). Although I thought it would be handy to be able to run it outside of installation if needed (fix broken paths, add a path entry for other users, etc) |
I've rerun the failed test, looks to be a flake |
@vrothberg PTAL |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I can't really review. I have no expertise in Windows at all, the code isn't executed in CI and there are barely any code comments.
But I am OK to merge as long as I don't have to main it :^)
1a20c64
to
e71ac09
Compare
@vrothberg I added some comments and also a little prompt for standalone usage. Let me know if anything looks confusing and needs additional commenting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Could you rebase on top of the latest HEAD? The e2e had a flake that has been fixed in the meantime.
e71ac09
to
7543658
Compare
Fixes containers#11089 - cleanup PATH on MSI uninstall Additionally fixes scenarios where the path can be overwritten by setx Also removes the console flash, since the helper is built as a silent gui Helper executable can be rerun by user to repair PATHs broken by other tools Utilizes executable location instead of passed parameters to remove delicate escaping requirements [NO NEW TESTS NEEDED] Signed-off-by: Jason T. Greene <[email protected]>
7543658
to
3ac5999
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Improves the Windows installation experience and fixes a few issues:
Fixes #11089 - cleanup PATH on MSI uninstall
Additionally fixes scenarios where the path can be overwritten by setx
Also removes the console flash, since the helper is built as a silent gui
Helper executable can be rerun by user to repair PATHs broken by other tools
Utilizes executable location instead of passed parameters to remove delicate escaping requirements
How to verify it
Which issue(s) this PR fixes:
Fixes #11089
Special notes for your reviewer:
None