when searching, survive errors for multiple registries #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // errors and other possibles errors | ||
| if len(registries) > 1 { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Might be good to have at least a debug statement above the continue.
There was a problem hiding this comment.
i believe it ends up in the journal
when searching multiple registries for images, if we get an error on one of the searches, we should keep going and complete the search. if there is only one search registry however, we will return an error. Resolves: containers#1255 Signed-off-by: baude <[email protected]>
baude
force-pushed
the
varlinksearcherror
branch
from
b38e6bb to
a04e7e1
Compare
|
lets merge this |
|
Sure |
|
I think we might need to get rh-atomic-bot added to the containers org, maybe? |
1 similar comment
|
📌 Commit a04e7e1 has been approved by |
|
⌛ Testing commit a04e7e1 with merge 8f3621f... |
|
I think I straight broke the papr tests by manually merging the systemd cgroups stuff |
|
💔 Test failed - status-papr |
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-papr |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when searching multiple registries for images, if we get an error on one
of the searches, we should keep going and complete the search. if there
is only one search registry however, we will return an error.
Resolves: #1255
Signed-off-by: baude [email protected]