specgen: honor empty args for entrypoint specified as --entrypoint ""
#12541
Conversation
openshift-ci
bot
added
the
approved
| @@ -409,7 +409,7 @@ func FillOutSpecGen(s *specgen.SpecGenerator, c *entities.ContainerCreateOptions | |||
| s.WorkDir = c.Workdir | |||
| if c.Entrypoint != nil { | |||
There was a problem hiding this comment.
Following block is only invoked when --entrypoint is set from CLI or remote-client
flouthoc
force-pushed
the
remote_blank_entrypoint
branch
from
36b30b6 to
abc301e
Compare
|
@cevich I think we are reaching some account limits in CI and i am not sure what could we do here. Do you have any ideas about this ? |
pkg/specgenutil/specgen.go
Outdated
| @@ -409,7 +409,7 @@ func FillOutSpecGen(s *specgen.SpecGenerator, c *entities.ContainerCreateOptions | |||
| s.WorkDir = c.Workdir | |||
| if c.Entrypoint != nil { | |||
| entrypoint := []string{} | |||
| if ep := *c.Entrypoint; len(ep) > 0 { | |||
| if ep := *c.Entrypoint; len(ep) >= 0 { | |||
There was a problem hiding this comment.
As written this check no longer does anything, you can just remove it.
Users should be able to override containers entrypoint using `--entrypoint ""` following works fine for podman but not for podman remote. Specgen ignores empty argument for entrypoint so make specgen honor empty arguments. Signed-off-by: Aditya Rajan <[email protected]>
flouthoc
force-pushed
the
remote_blank_entrypoint
branch
from
abc301e to
b526a0c
Compare
|
/approve |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's not our CI, it's the upstream download limit that's being hit (but we're not helping) 😞 Multiple PRs are hitting this. Fix is in containers/automation_images#103 and #12547 |
|
@edsantiago PTAL |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Thank you @flouthoc ! |
github-actions
bot
added
the
locked - please file new issue/PR
Users should be able to override containers entrypoint using
--entrypoint ""following works fine for podman but not for podmanremote since
CreateOptionsis not passed over to remote server.Specgen ignores empty argument for entrypoint so make specgen honor
empty arguments.
Closes: #12521