Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add spec file for automated copr builds #12491

Merged
merged 1 commit into from
Dec 3, 2021
Merged

add spec file for automated copr builds #12491

merged 1 commit into from
Dec 3, 2021

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Dec 2, 2021 •
edited
Loading

add spec file for automated copr builds

This commit along with an upstream webhook
will automatically build an rpm at
rhcontainerbot/podman-next .

RPM NVR will be of the form:
podman-4-$DATESTAMP.$TIMESTAMP

The date and time stamps will reflect the date and
time at which they were built in the COPR env
which shouldn't lag the PR merge date by a lot.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar [email protected]

What this PR does / why we need it:

This commit will automatically trigger rpm rebuilds of podman v4 on the copr rhcontainerbot/podman-next
https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/

How to verify it

Any PR merge should trigger a new build on the copr.
I have already added the copr webhook to podman's github repo.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Needed for early testing of podman with netavark since official Fedora packaging is gonna take forever, and I'm really not in the mood to argue with the Fedora rust gatekeepers until 2022.

@vrothberg @baude @mheon @Luap99 @rhatdan @cevich @edsantiago @TomSweeneyRedHat @flouthoc PTAL.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021
@lsm5
Copy link
Member Author

lsm5 commented Dec 2, 2021 •
edited
Loading

The subpackages like gvproxy, plugins and machine-cni have been excluded from here. I'm hoping people can just use the official Fedora subpackages.

Edit: In case official subpackages are not installable with this podman, I can shove them in here.

@lsm5
Copy link
Member Author

lsm5 commented Dec 2, 2021 •
edited
Loading

Anybody that needs access to the rhcontainerbot/podman-next COPR, please visit: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/permissions/ and check the Is Builder and Is Admin Boxes. I will then manually approve you there.

@lsm5
Copy link
Member Author

lsm5 commented Dec 2, 2021

If anyone's curious, I followed this process to setup the autobuild: https://hobo.house/2017/09/03/automate-rpm-builds-from-git-sources-using-copr/

@lsm5
Copy link
Member Author

lsm5 commented Dec 3, 2021 •
edited
Loading

@cevich @edsantiago is this a known failure? My PR shouldn't actually bother any existing tests.

Edit: spoke too soon, looks like it takes a few seconds to update results from cirrus.

@mheon
Copy link
Member

mheon commented Dec 3, 2021

LGTM

@mheon
Copy link
Member

mheon commented Dec 3, 2021

@containers/podman-maintainers PTAL

edsantiago
edsantiago approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be based on the fedpkg spec, not the one in contrib/spec, so that's what I compared against. One question, one sad-face for the removal of -tests, but LGTM overall. Thanks for doing this.

.autocopr/podman.spec Outdated Show resolved Hide resolved
@lsm5 lsm5 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2021
@lsm5 lsm5 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2021
@lsm5
Copy link
Member Author

lsm5 commented Dec 3, 2021

@edsantiago the rpm NVR will now look like: podman-4-$DATE.$TIME . I can add the tests back if these packages will be used for gating somewhere.

@lsm5 lsm5 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2021
@edsantiago
Copy link
Member

Thanks, I hope the %H%M%S is never needed but it's a good safety net. As for tests, I don't foresee a need for gating on this; and if tests are needed it's very easy to git-clone or rsync them. I think you're right to keep this spec as clean as possible.

@lsm5
Copy link
Member Author

lsm5 commented Dec 3, 2021

@edsantiago I don't wanna leave you with a sad face for the holidays :) .. Both your concerns should be addressed now. PTAL.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2021
@lsm5
Copy link
Member Author

lsm5 commented Dec 3, 2021

Thanks, I hope the %H%M%S is never needed but it's a good safety net. As for tests, I don't foresee a need for gating on this; and if tests are needed it's very easy to git-clone or rsync them. I think you're right to keep this spec as clean as possible.

Too late, tests are added now :)

@edsantiago
Copy link
Member

So I just saw! LGTM, and thanks.

@lsm5
Copy link
Member Author

lsm5 commented Dec 3, 2021

@edsantiago Given that a bunch of PRs get merged everyday, I'm sure we'll need the %H%M%S. So, really appreciate that pointed out. Sending the same change on the netavark side too.

@rhatdan
Copy link
Member

rhatdan commented Dec 3, 2021

/approve
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, lsm5, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [edsantiago,lsm5,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member Author

lsm5 commented Dec 3, 2021

@rhatdan mergeme

@lsm5 lsm5 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2021
@lsm5
Copy link
Member Author

lsm5 commented Dec 3, 2021

i need to adjust builddeps to make centos stream happy. sending a change in a bit

@lsm5
add spec file for automated copr builds
8e05326 
This commit along with an upstream  webhook
will automatically build an rpm at
`rhcontainerbot/podman-next` .

RPM NVR will be of the form:
podman-4-$DATESTAMP.$TIMESTAMP

The date and time stamps will reflect the date and
time at which they were built in the COPR env
which shouldn't lag the PR merge date by a lot.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2021
@lsm5 lsm5 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2021
@lsm5
Copy link
Member Author

lsm5 commented Dec 3, 2021

@rhatdan i added a one-line change in the package name of go-md2man to make centos 9 stream happy. No other change.

@rhatdan
Copy link
Member

rhatdan commented Dec 3, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2021
@rhatdan
Copy link
Member

rhatdan commented Dec 3, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit a03b8b4 into containers:main Dec 3, 2021
@lsm5 lsm5 deleted the auto-copr branch February 4, 2022 14:39
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago edsantiago approved these changes

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lsm5 @mheon @edsantiago @rhatdan @openshift-merge-robot