cmd, push: use the configured compression format #12486
Conversation
Signed-off-by: Giuseppe Scrivano <[email protected]>
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rhatdan PTAL |
cmd/podman/images/push.go
Outdated
| @@ -109,7 +109,7 @@ func pushFlags(cmd *cobra.Command) { | |||
| flags.BoolVar(&pushOptions.TLSVerifyCLI, "tls-verify", true, "Require HTTPS and verify certificates when contacting registries") | |||
|
|
|||
| compressionFormat := "compression-format" | |||
| flags.StringVar(&pushOptions.CompressionFormat, compressionFormat, "", "compression format to use") | |||
| flags.StringVar(&pushOptions.CompressionFormat, compressionFormat, containerConfig.Engine.CompressionFormat, "compression format to use") | |||
There was a problem hiding this comment.
You should not set this hear, it needs to be set on the server side not the client side.
There was a problem hiding this comment.
Should be handled here:
https://github.com/containers/podman/blob/main/pkg/domain/infra/abi/images.go#L309-L315
There was a problem hiding this comment.
I thought we wanted from the client side (so that it reflects in the podman push --help output).
I've pushed a new version where it is set in pkg/domain/infra/abi/images.go
[NO NEW TESTS NEEDED] I am just changing the default value Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
use-configured-compression-format
branch
from
17d813c to
bd9f881
Compare
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
follow up for #12450
Signed-off-by: Giuseppe Scrivano [email protected]