e2e tmpdir cleanup #12471
Merged
e2e tmpdir cleanup #12471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
edsantiago
force-pushed
the
e2e_tmpdir_cleanup
branch
from
08d11f8 to
0b49ec3
Compare
|
LGTM |
|
BTW CRIO is just because Podman came out of the original CRIO effort as kpod, and we stole CRIO test suite and never changed the name. |
...and remove other uses of "crio". They're confusing and misleading. (I'm sure it made sense at one time) Signed-off-by: Ed Santiago <[email protected]>
Images were being cached in /tmp, with no option to override. Now $PODMAN_TEST_IMAGE_CACHE_DIR can be used to point to a user-preferred location. If unset, try $TMPDIR before settling on /tmp. Also: refactor the logic for determining the tarball name. Also: include registry name in tarball name. Also: clean up unused/unnecessary code Also: do not echo "Restoring..." if we're not actually restoring. Signed-off-by: Ed Santiago <[email protected]>
...they're not actually used for anything Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
e2e_tmpdir_cleanup
branch
from
0b49ec3 to
6510949
Compare
|
Changes LGTM, now to get the test happy. |
|
It's just #9597, one of our most popular flakes |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial goal was to allow caching the e2e images in a directory other than /tmp.
In the process of doing so I discovered some very confusing and/or unnecessary code.
I took the liberty of cleaning it up.
These are three separate easily-reviewed commits, I recommend reviewing each separately: