Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname in spec.hostname should be passed to infra ctr init opt #12466

Conversation

dispensable
Copy link

Pass spec.hostname to infra ctr init options so we can set hostname as user expected.

Fixes #12393

Signed-off-by: Qiang Wang [email protected]

What this PR does / why we need it:

When create pod with yaml file by play kube cmd. hostname setted on yaml spec did not passed to infra hostname opt. This cause the UTS namespace use default pod name as hostname.

How to verify it

In the issue I submitted enough info already.

Which issue(s) this PR fixes:

Fixes #12393

Special notes for your reviewer:

N/A

@rhatdan
Copy link
Member

rhatdan commented Dec 1, 2021

LGTM
@vrothberg @cdoern @mheon @umohnani8 PTAL

@mheon
Copy link
Member

mheon commented Dec 1, 2021

LGTM on my end, but I'd like a look from @cdoern before merging

@TomSweeneyRedHat
Copy link
Member

LGTM
@cdoern WDYT?

@cdoern
Copy link
Contributor

cdoern commented Dec 3, 2021

LGTM, I've been meaning to circle back to the kube side of things when it comes to the new infra ctr implementation. This is a good fix for hostname but there are probably other issues like this dangling around.

@rhatdan
Copy link
Member

rhatdan commented Dec 3, 2021

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dispensable, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 3, 2021
@rhatdan
Copy link
Member

rhatdan commented Dec 3, 2021

Thanks alot @dispensable

@openshift-merge-robot openshift-merge-robot merged commit a93fa5e into containers:main Dec 3, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman play kube does not respect spec.hostname setting
6 participants