Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Update doc to explictly mention using ed25519 in ssh keys #12445

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

wilbeibi
Copy link
Contributor

What this PR does / why we need it:

Looks like many people stumble upon this issue #8323 (so do I), maybe it worth to mention it in the doc the ssh key pair is ed25519.

How to verify it

Which issue(s) this PR fixes:

Fixes #8323

Special notes for your reviewer:

@rhatdan
Copy link
Member

rhatdan commented Nov 30, 2021

/approve
LGTM
Thanks @wilbeibi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, wilbeibi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@flouthoc
Copy link
Collaborator

flouthoc commented Dec 1, 2021

@wilbeibi Could you please sign the commit.

@Luap99
Copy link
Member

Luap99 commented Dec 2, 2021

Can you squash your commits into one please.

@rhatdan
Copy link
Member

rhatdan commented Dec 2, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8bce756 into containers:main Dec 2, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to authenticate with podman-remote over ssh to drive remote podman.sock
6 participants