-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the containerfile not found during remote build #12425
Fixed the containerfile not found during remote build #12425
Conversation
CI is complaining that a new test is required |
Change LGTM overall |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, tnk4on The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please squash your commits. |
LGTM |
could you add a test? |
The test for this PR is the same as #11755. Do I need to add anything? Please give me some ideas. The cause of this PR is that the client and server were tested by the same host, so the problem was overlooked and the #11755 fix was incomplete. |
I do not think we can add a test where client and server are on separate systems. One reason more for podman machine testing. |
ok fair. Could you please add |
[NO NEW TESTS NEEDED] Signed-off-by: Shion Tanaka <[email protected]>
Symlinks always give me the heebie-jeebies, but this LGTM |
/lgtm |
@mheon Another possible backport for 3.4. |
What this PR does / why we need it:
Fixed the
containerfile
not found during remote build when the context directory is symlink.How to verify it
Which issue(s) this PR fixes:
Fixes #12409
Special notes for your reviewer:
#11755 is insufficient to fix Issue #11732.
#11755 only works in the following cases.
(e.g. The client and server have the same context directory and Containerfile.)
Signed-off-by: Shion Tanaka [email protected]