Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the containerfile not found during remote build #12425

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Fixed the containerfile not found during remote build #12425

merged 1 commit into from
Dec 2, 2021

Conversation

tnk4on
Copy link
Contributor

@tnk4on tnk4on commented Nov 27, 2021

What this PR does / why we need it:

Fixed the containerfile not found during remote build when the context directory is symlink.

How to verify it

  • Prepare the podman remote environment for the client and server.
  • Put the context directory and Containerfile on the client side only.
  • Create a symlink for the context directory. (e.g. ln -s target link)
  • Execute a remote build by specifying symlink for the context directory.(e.g. podman -r build -t remote-build link)

Which issue(s) this PR fixes:

Fixes #12409

Special notes for your reviewer:

#11755 is insufficient to fix Issue #11732.

#11755 only works in the following cases.
(e.g. The client and server have the same context directory and Containerfile.)

Signed-off-by: Shion Tanaka [email protected]

@mheon
Copy link
Member

mheon commented Nov 29, 2021

CI is complaining that a new test is required

@mheon
Copy link
Member

mheon commented Nov 29, 2021

Change LGTM overall

@mheon
Copy link
Member

mheon commented Nov 29, 2021

/approve

@rhatdan @jwhonce PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, tnk4on

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2021

Please squash your commits.

@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2021

LGTM
@Luap99 @giuseppe PTAL

@umohnani8
Copy link
Member

LGTM

@giuseppe
Copy link
Member

could you add a test?

@tnk4on
Copy link
Contributor Author

tnk4on commented Nov 30, 2021

The test for this PR is the same as #11755. Do I need to add anything? Please give me some ideas.

https://github.com/containers/podman/pull/11755/files#diff-c5e29dbfa8d0225bea760a6935c60db51f2d9ad9535073a7f9e254682b60b487

The cause of this PR is that the client and server were tested by the same host, so the problem was overlooked and the #11755 fix was incomplete.
If we want to do a complete remote test, we need to change the UNIX Socket specification (I don't think it's that necessary).

@Luap99
Copy link
Member

Luap99 commented Nov 30, 2021

I do not think we can add a test where client and server are on separate systems. One reason more for podman machine testing.

@giuseppe
Copy link
Member

giuseppe commented Nov 30, 2021

ok fair. Could you please add [NO NEW TESTS NEEDED] to your commit message when you squash the two commits?

[NO NEW TESTS NEEDED]

Signed-off-by: Shion Tanaka <[email protected]>
@TomSweeneyRedHat
Copy link
Member

Symlinks always give me the heebie-jeebies, but this LGTM
I've restarted the failing test, looks to be a flake.

@Luap99
Copy link
Member

Luap99 commented Dec 2, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
@Luap99
Copy link
Member

Luap99 commented Dec 2, 2021

@mheon Another possible backport for 3.4.

@openshift-merge-robot openshift-merge-robot merged commit eeb7149 into containers:main Dec 2, 2021
@tnk4on tnk4on deleted the remote-build-eval-containerfile branch December 2, 2021 14:07
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman-remote: Cannot build if context directory is symlink
8 participants